Skip to content

Add support for returning tags and custom_attributes in the d/vsphere_virtual_machine data source #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akli-ime wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add support for returning tags and custom_attributes in the d/vsphere_virtual_machine data source #2652

akli-ime wants to merge 7 commits into from
+48 −1

Conversation

@akli-ime
Copy link

@akli-ime akli-ime commented Dec 26, 2025

Description

This pull request adds support for returning tags and custom_attributes in the vsphere_virtual_machine data source.

  • Tags are returned as a list of vSphere tag IDs attached to the virtual machine.
  • Custom attributes are returned as a map of custom attribute IDs to their corresponding values.

This improves visibility of vSphere metadata when using the data source.

Related Issue

Fixes #2615

@akli-ime akli-ime requested a review from a team as a code owner December 26, 2025 16:05
@github-actions github-actions bot added documentation Documentation provider Provider needs-review Needs Review size/s Relative Sizing: Small labels Dec 26, 2025
@akli-ime akli-ime mentioned this pull request Dec 26, 2025
Open
4 tasks
spacegospod
spacegospod reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please run golangci-lint locally and fix the formatting errors it reports.
Make sure to use v2.1.6 so that it matches the one on the GitHub action.

If you need any help with it just let me know.

tenthirtyam
tenthirtyam requested changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move internal imports together in alphabetical order.

Add descriptions for new attributes.

spacegospod
spacegospod requested changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akli-ime Looks good, I tried to apply @tenthirtyam 's suggestions into comments to help move this forward.

@akli-ime
Copy link
Author

akli-ime commented Jan 19, 2026

@spacegospod Thanks a lot! I’ve reviewed the comments and really appreciate you taking the time to incorporate @tenthirtyam’s suggestions. This is very helpful for moving things forward.

@spacegospod
Copy link
Contributor

spacegospod commented Jan 19, 2026

@spacegospod Thanks a lot! I’ve reviewed the comments and really appreciate you taking the time to incorporate @tenthirtyam’s suggestions. This is very helpful for moving things forward.

Looks like 4 imports got duplicated and are failing the lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenthirtyam tenthirtyam tenthirtyam requested changes

@spacegospod spacegospod spacegospod requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

documentation Documentation needs-review Needs Review provider Provider size/s Relative Sizing: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for returning tags and custom_attributes in the d/vsphere_virtual_machine data source

3 participants

@akli-ime @spacegospod @tenthirtyam